From 18fe99e1c3aaadd0225b23f5d67dc65dd4a432cc Mon Sep 17 00:00:00 2001
From: shopkeeperdev <taber@shopkeeper.dev>
Date: Tue, 4 Nov 2025 17:03:56 -0500
Subject: [PATCH] Fix admin menu icon box: robust CSS selectors to hide
 pseudo-icon for vendorsalesreport menu

---
 view/adminhtml/web/css/vendor-report.css | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/view/adminhtml/web/css/vendor-report.css b/view/adminhtml/web/css/vendor-report.css
index 2fbfe42..e912e1d 100644
--- a/view/adminhtml/web/css/vendor-report.css
+++ b/view/adminhtml/web/css/vendor-report.css
@@ -1,11 +1,17 @@
-/* Vendor Sales Report Menu - Remove icon */
-.item-vendorsalesreport > a:before {
-    display: none !important;
-}
+/* Vendor Sales Report Menu - Hide icon/pseudo-element reliably
+   Some Magento admin menu item class names vary depending on how the
+   menu id is normalized (module and item id). Targetting the generated
+   class used by this module may not always match, which causes a
+   leftover glyph/box to appear. Use the menu link href as a reliable
+   selector and include broader admin menu selectors so the icon is
+   removed even if the class name differs. */
 
-/* Additional targeting for stubborn icons */
-#menu-magento-reports-report .item-vendorsalesreport > a:before,
-.admin__menu .item-vendorsalesreport > a:before {
+/* Target by href that contains the admin route for this module */
+#menu a[href*="vendorsalesreport/report/index"]::before,
+.admin__menu a[href*="vendorsalesreport/report/index"]::before,
+/* Fallback: any menu item with vendorsalesreport in its class name */
+.admin__menu [class*="vendorsalesreport"] > a::before,
+.admin__menu [class*="vendorsalesreport"] > a:before {
     content: none !important;
     display: none !important;
     width: 0 !important;
@@ -13,3 +19,6 @@
     margin: 0 !important;
     padding: 0 !important;
 }
+
+/* Historic selector kept for backward compatibility */
+.item-vendorsalesreport > a:before { display: none !important; }